feat: harden premium payment date progression logic#415
Merged
Baskarayelu merged 2 commits intoRemitwise-Org:mainfrom Mar 28, 2026
Merged
Conversation
Implement deterministic next_payment_date updates to prevent schedule drift: - Add PREMIUM_INTERVAL_SECONDS constant (30 days) for consistent interval usage - Modify pay_premium to advance from previous due date, not current timestamp - Handle late payments by advancing until next_due is in the future - Prevent schedule manipulation through early or late payment timing The new logic ensures: - Early payments don't shift the schedule forward - Late payments don't double-cover periods - Payment schedules remain predictable regardless of payment timing Test coverage includes: - Early payment scenarios (5-15 days early) - On-time payment boundary cases - Late payment single/multiple period scenarios - Mixed early/late payment sequences over 12 months - Boundary condition at exactly next_due timestamp Resolves: premium payment date drift issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement deterministic next_payment_date updates to prevent schedule drift:
The new logic ensures:
Test coverage includes:
Resolves: premium payment date drift issue
Closes #278